[PATCH 2/6] d3drm: Implement IDirect3DRM*::CreateViewport. (v2 resend)

[Stefan Dösinger]

On 2016-07-27 20:27, Aaryaman Vasishta wrote:
> 
> 
> On Thu, Jul 28, 2016 at 12:21 AM, Stefan Dösinger
> <stefandoesinger at gmail.com <mailto:stefandoesinger at gmail.com>> wrote:
> 
>     > +    if (!device || !camera)
>     > +        return D3DRMERR_BADOBJECT;
>     > +    if (!viewport)
>     > +        return D3DRMERR_BADVALUE;
>     These checks are redundant, Init() does that as well.
> 
> Agreed for version 3 of CreateViewport, but this this apply for version
> 1/2 as well? Since I'm dereferencing these interfaces there I thought
> the checks were justified.
No, in 1 and 2 you need them as you say. Otherwise you'll crash when you
try to call QI.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160727/a5fd7ef0/attachment.sig>