[PATCH 1/4] mpr: Implement local name automatic redirection for disks.

[Pierre Schweitzer]

Hi,

I wanted to avoid yet another recopy (in the ANSI case) especially since
input is well-known: user necessarily provided NULL ptr to reach that point.
But, if you prefer, I can do another copy. But in the ANSI case, it will
mean that NETRESOURCE structure has been copied twice (rather expensive).

Cheers,

Le 28/07/2016 à 09:50, Alexandre Julliard a écrit :
> Pierre Schweitzer <pierre at reactos.org> writes:
> 
>> +done:
>> +    if (redirect)
>> +        ctxt->resource->lpLocalName = NULL;
> 
> It looks quite suspicious to modify that input parameter and restore it
> at the end. You should probably use a copy instead.
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3960 bytes
Desc: Signature cryptographique S/MIME
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160728/4493707a/attachment-0001.bin>