[PATCH 2/2 v4] ucrtbase: Add _get_narrow_winmain_command_line tests

Dmitry Timoshkov dmitry at baikal.ru
Thu Jul 28 06:33:24 CDT 2016


Piotr Caban <piotr at codeweavers.com> wrote:

> >> +    sprintf(cmd, "\"\"%c\"\"\"%s\" \t \"misc\" cmd", name[0], name+1);
> >> +    memset(&startup, 0, sizeof(startup));
> >> +    startup.cb = sizeof(startup);
> >> +    CreateProcessA(path, cmd, NULL, NULL, TRUE,
> >> +            CREATE_DEFAULT_ERROR_MODE|NORMAL_PRIORITY_CLASS,
> >> +            NULL, NULL, &startup, &proc);
> >> +    winetest_wait_child_process(proc.hProcess);
> >
> > Thanks for adding the tests. It shouldn't be too hard to also test other
> > white space characters, at least testing '\r' and '\n' would be nice to
> > have.
> >
> CreateProcess will fail in case of '\r' or '\n' characters.

In a simple test CreateProcess() works just fine here under Windows 7 when a
passed in command line contains '\r' and/or '\n', where does it fail for you?

-- 
Dmitry.



More information about the wine-devel mailing list