comctl32/tests: Avoid using memset() on RECTs.

Michael Stefaniuc mstefani at redhat.com
Sat Jul 30 15:18:33 CDT 2016


On 07/30/2016 09:58 PM, Nikolay Sivov wrote:
> On 30.07.2016 22:55, Michael Stefaniuc wrote:
>> -    memset(&r1, 0, sizeof r1);
>> -    r1.left = LVIR_ICON;
>> +    SetRect(&r1, LVIR_ICON, 0, 0, 0);
> 
> I don't like this, I think it's better to use SetRect() when actual
> coordinates are used, and LVIR_* has special meaning.
Uhm? I have added 36 of those with commit 87bc2aa6 and you signed of on
that.

For me those are still RECTs even though MS uses them for other stuff.

bye
	michael



More information about the wine-devel mailing list