[PATCH v2 1/2] msi/tests: Test for ErrorControl-flag

Hans Leidekker hans at codeweavers.com
Mon Jun 6 03:17:33 CDT 2016


On Fri, 2016-06-03 at 19:03 +0200, Andreas Maier wrote:
> This test expands a already existing test.
> A Service is installed with the special ErrorControl-flag
> 0x8000 (msidbServiceInstallErrorControlVital).
> The flag should be filtered out be msi. The test checks,
> if the service is created without this flag.

Looks good.

> Besides it fixes a bug in test_delete_services.
> TestService was not deleted after testing.

Please submit this as a separate patch and resend the whole set
labeled [1/3], [2/3] and [3/3]. You also need put the fix first or
mark the test todo_wine because tests should never fail on Wine
between two patches.





More information about the wine-devel mailing list