[PATCH 5/5] ddraw/tests: Remove p8_primary_test.

Tue Jun 7 14:42:23 CDT 2016

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-06-07 um 16:18 schrieb Henri Verbeet:
> That's likely all true, but those would be reasons for fixing the
> test instead of removing it. Do the previous two tests in the
> series cover all the functionality tested by this test?
In the past you rejected even typo fixes in the old files :-) .

Covering the functionality in the new tests was the intention, yeah.
The color table verification already exists in test_palette_gdi. The
two patches add the GetDC color verification and Blitting tests,
although they test the blit result through locking the surface instead
of reading it through GetDC. Because the DIB is and always has been
based on the P8 data this doesn't make a difference.

I didn't take the lock - blit - lock - blit test along because we have
many other tests that check our texture upload and download codepaths.
Since we're doing P8 conversion only when showing the final front
buffer P8 transfers aren't special in that regard any more.