[PATCH 1/2 v2] user32: Show that mouse move message is generated every time window position is changed

Piotr Caban piotr.caban at gmail.com
Wed Jun 8 09:09:01 CDT 2016


On 06/08/16 15:49, Dmitry Timoshkov wrote:
> Piotr Caban <piotr at codeweavers.com> wrote:
>
>> v2:
>>   - only patch 2 was changed (fixed detection when message should be
>> generated)
>
> If only the patch 2 was changed that means that the tests don't really
> cover the implementation. That rises the questions: how the logic in the
> patch 2 was actually discovered, and what else is missing in the tests
> and the implementation?
The tests are not covering all combinations of flags passed to 
SetWindowPos (and I think there's no need for that). An example of test 
that will fail with first version of patch is added in patch 2.

Anyway I'll add few more tests for completeness.



More information about the wine-devel mailing list