[PATCH 2/4] d3drm: Fix frame object creation method.

Aaryaman Vasishta jem456.vasishta at gmail.com
Thu Jun 9 08:28:25 CDT 2016


Right, I understand, it makes sense. I'll avoid the cast and reorder the
things. :)

Cheers,
Aaryaman

On Thu, Jun 9, 2016 at 6:34 PM, Henri Verbeet <hverbeet at gmail.com> wrote:

> On 9 June 2016 at 14:57, Aaryaman Vasishta <jem456.vasishta at gmail.com>
> wrote:
> > Not even if it's fixed in patch 3/4?
> > I don't mind remaking the patches, but still wondering why.
> >
> Mostly because patches are supposed to stand on their own. I.e., if
> only the first two patches of the series would be applied, they should
> still make sense. And during a bisect, you can very well end up in the
> middle of such a series. The patch doesn't really change the behaviour
> of course, so in that regard you could just add a cast and remove it
> again in the following patch. Still, if you can reorder things in a
> way that avoids that cast, that's even better.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160609/909a70e4/attachment.html>


More information about the wine-devel mailing list