[PATCH] msvcrt/tests: Add tests for mbstowcs and wcstombs with a negative count.

Piotr Caban piotr.caban at gmail.com
Mon Jun 13 05:21:20 CDT 2016


Hi Alex,

On 06/12/16 22:07, Alex Henrie wrote:
> +    ret = mbstowcs(wOut, mSimple, -1);
> +todo_wine
> +    ok(ret == -1 || broken(ret == 4) /* xp */, "mbstowcs returned %i instead of -1\n", ret);
This will cause compilation warning:
../../../../wine_src/dlls/msvcrt/tests/string.c:1863:5: warning: format 
'%i' expects argument of type 'int', but argument 3 has type 'size_t' 
[-Wformat=]
      ok(ret == -1 || broken(ret == 4) /* xp */, "mbstowcs returned %i 
instead of -1\n", ret);

I'm also not sure if Windows XP behavior should be marked as broken. For 
me newer systems behavior is broken (doesn't handle strings longer then 
INT_MAX). Do you have an application that depends on it?

Thanks,
Piotr



More information about the wine-devel mailing list