[v4 1/4] winejoystick.drv/joystick_osx.c: fixes Ry/Rx -> U/V axes mapping

DavidL david.dljunk at gmail.com
Tue Jun 14 19:58:55 CDT 2016


For the axes mapping, I think I figured out what the pattern is, why Ry
maps to U and Rx to V.

For the primary axes, the order is X, Y, Z. For the secondary/rotational
axes, the expected fill order of the axes is Rz (joystick twist handle),
Ry, Rx; they inverted the list and in Winmm these latter axes correspond to
R, U, V.

The newest patch (coming soon) will have the original enum order
{X,Y,Z,Rx,Ry,Rz} and I've written next to the Rx,Ry,Rz comment labels with
the corresponding Winmm mapping axes V, U, R. The axes mapping in joyPosEx
has been changed to reflect the enum order.

Cheers,
David

On Mon, Jun 13, 2016 at 11:28 PM, Ken Thomases <ken at codeweavers.com> wrote:

> On Jun 14, 2016, at 12:57 AM, DavidL <david.dljunk at gmail.com> wrote:
>
>
> On Mon, Jun 13, 2016 at 2:44 PM, Ken Thomases <ken at codeweavers.com> wrote:
>
>> That said, I would prefer if you kept the order of the axes enum the same
>> (consistently x, y, z order) and changed the order of the axis_map table in
>> driver_joyGetPosEx(), instead.
>
>
> Sure I think I can change that. To make certain (line #s are for fully
> patched file): so instead of swapping lines 101-102 as I did, I would swap
> lines 734 & 735? That seems like the only change I would have to make to
> keep the original enum order and change the axes mapping ... does that seem
> right? (lines 687 & 688 would stay as I have them)
>
>
> Yes, that's correct.
>
> Thanks,
> Ken
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160614/036ad135/attachment.html>


More information about the wine-devel mailing list