Fwd: [v5 5/5] winejoystick.drv/joystick_osx.c: ignore feature elements

[DavidL]

I made the changes to the patches we talked about and added the patch
below. All it does is ignore "feature"-type elements which aren't meant for
end user consumption, suppressing the FIXME message in Trace logs for those
elements. Since these element types are un-handled by Winmm, I don't think
a FIXME message is necessary for them. However, if you feel we should keep
the fixme messages in place, I'm fine with that too.

Cheers,
David

---------- Forwarded message ----------
From: David Lawrie <david.dljunk at gmail.com>
Date: Tue, Jun 14, 2016 at 8:33 PM
Subject: [v5 5/5] winejoystick.drv/joystick_osx.c: ignore feature elements
To: wine-patches <wine-patches at winehq.org>
Cc: David Lawrie <david.dljunk at gmail.com>


"Describes input and output elements not intended for consumption by the
end user."
Ignore, as otherwise, comes up as a FIXME in Trace logs.

Source:
https://developer.apple.com/library/mac/documentation/IOKit/Reference/
IOHIDKeys_iokit_header_reference/#//apple_ref/c/tdef/IOHIDElementType

Tested on OS X 10.10.5.

Signed-off-by: David Lawrie <david.dljunk at gmail.com>
---
 dlls/winejoystick.drv/joystick_osx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/winejoystick.drv/joystick_osx.c
b/dlls/winejoystick.drv/joystick_osx.c
index ad82dd7..12ccff7 100644
--- a/dlls/winejoystick.drv/joystick_osx.c
+++ b/dlls/winejoystick.drv/joystick_osx.c
@@ -514,6 +514,9 @@ static void collect_joystick_elements(joystick_t*
joystick, IOHIDElementRef coll
                 }
                 break;
             }
+            case kIOHIDElementTypeFeature:
+                /* Describes input and output elements not intended for
consumption by the end user. Ignoring. */
+                break;
             default:
                 FIXME("Unhandled type %i\n",type);
                 break;
--
1.7.12.4 (Apple Git-37)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160614/4b26cdfe/attachment-0001.html>