[PATCH 3/5] d3drm/tests: Add refcount tests for IDirect3DRMFrame*. (v2)

Wed Jun 15 16:18:36 CDT 2016

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-06-15 um 10:35 schrieb Aaryaman Vasishta:
> +    ok(ref1 == ref2, "Expected ref1 == ref2, got ref1 = %u, ref2 = %u.\n", ref1, ref2);
> +    ok(ref2 == ref3, "Expected ref2 == ref3, got ref2 = %u, ref3 = %u.\n", ref2, ref3);
> +    ok(ref1 == ref3, "Expected ref1 == ref3, got ref1 = %u, ref3 = %u.\n", ref1, ref3);
I think you can assume basic logic still applies to d3drm :-) . There's
no need to test ref1 == ref3 after you made sure (ref1 == ref2 && ref2
== ref3) .

More importantly though, patch 5 somewhat suggests that you're planning
to have a full-blown QI and refcounting test for frames too. If that's
the case there's no need to add this patch.