[PATCH 1/4] d3drm: Add stubs for IDirect3DRMFrame interface. (v4)

[Aaryaman Vasishta]

On Fri, Jun 17, 2016 at 7:23 PM, Henri Verbeet <hverbeet at gmail.com> wrote:

> On 17 June 2016 at 15:40, Aaryaman Vasishta <jem456.vasishta at gmail.com>
> wrote:
> > On Fri, Jun 17, 2016 at 6:44 PM, Henri Verbeet <hverbeet at gmail.com>
> wrote:
> >> This may have come up before, but any reason you can't call
> >> d3drm_frame3_QueryInterface() directly here?
> >
> > I could probably put these stubs after version 3, but wouldn't that make
> the
> > version order in the file 2->3->1? Maybe a separate patch could
> rearrange it
> > to 3->2->1. Maybe we could do that after these stubs are added.
> >
> I'd make the order
>
>     d3drm_frame3_QueryInterface()
>     d3drm_frame2_QueryInterface()
>     d3drm_frame1_QueryInterface()
>     d3drm_frame3_AddRef()
>     d3drm_frame2_AddRef()
>     d3drm_frame1_AddRef()
>     etc.
>
> I'd don't care so much if you move the version 2 functions in the same
> patch that introduces the version 1 functions, although I think it
> makes sense to do that in a separate patch.
>
Right, will get right on it. I'll first write a patch to rearrange it and
rebase these patches on top of it. Please review the other patches in the
mean time if possible. Thanks for the review!

Cheers,
Aaryaman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160617/90c77389/attachment.html>