[PATCH 1/4] d3drm: Add stubs for IDirect3DRMFrame interface. (v4)

Stefan Dösinger stefandoesinger at gmail.com
Fri Jun 17 13:14:22 CDT 2016


> Am 17.06.2016 um 14:40 schrieb Aaryaman Vasishta <jem456.vasishta at gmail.com>:
> 
> > Doesn't that potentially break currently working applications? And
> > while having tests is great, I'm not sure I agree with the premise
> > that it's better to return E_NOTIMPL than to forward to an
> > implementation that may have subtle differences but probably doesn't
> > in most cases.

> I don't disagree with you. I just want an acceptable patch for this as I'll need it for implementing viewports. Also a lot of version 2 stuff uses version 1 frames as well, which makes it more important. I've CC'd Stefan in this mail, hopefully we can agree on something which works for all.
I am fine with imperfect / possibly broken thunks. What I want to avoid is wasting too much time on possible corner cases for a thunk that thunks to an E_NOTIMPL or barely implemented function. I guess I forgot about the possibility that the existing Frame code runs any real application :-\ .

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20160617/0b9429d5/attachment.sig>


More information about the wine-devel mailing list