[2/8] msvcirt: Implement ostream::operator<< for characters

Piotr Caban piotr.caban at gmail.com
Tue Jun 21 06:13:16 CDT 2016


On 06/21/16 11:54, Iván Matellanes wrote:
> @@ -2608,8 +2615,7 @@ ostream* __thiscall ostream_print_char(ostream *this, char c)
>  DEFINE_THISCALL_WRAPPER(ostream_print_unsigned_char, 8)
>  ostream* __thiscall ostream_print_unsigned_char(ostream *this, unsigned char c)
>  {
> -    FIXME("(%p %c) stub\n", this, c);
> -    return this;
> +    return ostream_print_char(this, (char) c);
>  }
The cast here is not needed.

> +    pssb = (strstreambuf*) call_func1(p_strstreambuf_ctor, &ssb);
> +    ok(pssb == &ssb, "wrong return, expected %p got %p\n", &ssb, pssb);
> +    pos = (ostream*) call_func3(p_ostream_sb_ctor, &os, (streambuf*) &ssb, TRUE);
As well as this ones. Such casts can potentially hide problems otherwise 
visible during 64-bit compilation.

> +            pos = (ostream*) call_func2(p_ostream_print_char, &os, (int) tests[i].param.c); break;
The cast here is also not needed.

Thanks,
Piotr




More information about the wine-devel mailing list