[PATCH] d3dx9: Avoid overflowing debug channel buffer when tracing ASCII effect errors.

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Tue Jun 28 17:50:21 CDT 2016


Hi Matteo,

On 29/06/16 03:06, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
> ---
> Inspired by a patch by Alistair Leslie-Hughes.
> 
>  dlls/d3dx9_36/effect.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
trace:d3dx:d3dx9_base_effect_init "Shaders/commonVertexLight.fx(53,7):
warning X3205: conversion from larger type t"
trace:d3dx:d3dx9_base_effect_init "o smaller, possible loss of data"
trace:d3dx:d3dx9_base_effect_init "Shaders/commonVertexLight.fx(55,9):
warning X3205: conversion from larger type t"
trace:d3dx:d3dx9_base_effect_init "o smaller, possible loss of data"
trace:d3dx:d3dx9_base_effect_init "StaticMesh.fx(484,39): warning X3206:
implicit truncation of vector type"


Hers is the output from your patch. The first too lines are warnings are
split across trace statement. Should we use a larger number to attempt
to have each error/warning on one line.

Best Regards
 Alistair Leslie-Hughes


More information about the wine-devel mailing list