[PATCH] d3dx9: implement effect state management.

Henri Verbeet hverbeet at gmail.com
Tue Mar 1 07:48:10 CST 2016


>> +static void test_effect_states(IDirect3DDevice9 *device)
>> +{
>> +    D3DMATRIX test_mat =
>> +    {
>> +        {
>> +        -1.0f, 0.0f, 0.0f, 0.0f,
>> +        0.0f, 0.0f, 0.0f, 0.0f,
>> +        0.0f, 0.0f, 0.0f, 0.0f,
>> +        0.0f, 0.0f, 0.0f, 0.0f
>> +        }
>> +    };
>> +    D3DMATRIX mat;
>> +    HRESULT hr;
>> +    ID3DXEffect *effect;
>> +    UINT cPasses;
>
> No camelcase or similar, just lowercase with underscores.
>
Somewhat related, "This" really isn't a great variable name.
Unfortunately it's fairly common in Wine source, I suppose it's
something people picked up from C++ and then propagated.



More information about the wine-devel mailing list