[PATCH] d3dx9: IsParameterUsed stub should return TRUE.

[Matteo Bruni]

2016-03-08 19:16 GMT+01:00 Paul Gofman <gofmanp at gmail.com>:
> On 03/08/2016 09:08 PM, Matteo Bruni wrote:
>> I get your point, that's why I signed off your patch :) Henri's point
>> was also valid though. The other option was to not include this patch
>> upstream (keeping this patch or your work-in-progress implementation
>> in your private tree for testing purposes) and only submit the final
>> IsParameterUsed() implementation when it's ready. In the end this
>> means I'm trusting you to submit a proper implementation with tests
>> later on.
> Thanks, I will do it after we finish preshaders. I am going to set first
> version of this patchset soon (tomorrow as latest).
> BTW while testing preshader math operation result I found a few
> mismatches between different Windows versions (32 bit and 64 bit
> actually). Could you please recommend a right way to deal with it in
> Wine tests?

It depends but, if it has to do with float results precision, probably
just allowing for a little tolerance is fine (see the compare_float()
in d3dx9_36/tests/effect.c).