[PATCH 2/2] ddraw/tests: Use SetRect() instead of open coding it.

[Michael Stefaniuc]

On 03/22/2016 10:59 AM, Marvin wrote:
> Hi,
> 
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=21571
> 
> Your paranoid android.
> 
> 
> === w864 (32 bit d3d) ===
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level
> d3d.c:2492: Test failed: Unexpected destination texture level pixels; 257 differences
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level
> 
> === w1064 (32 bit d3d) ===
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level
> d3d.c:2311: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level
> d3d.c:2492: Test failed: Unexpected destination texture level pixels; 257 differences
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level
> d3d.c:2636: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

This are unrelated and pre-existing failures:
https://test.winehq.org/data/bc357819296594aca300fdf30bb0cda46e9f0be0/win8_newtb-w8/ddraw:d3d.html



> === w8 (32 bit visual) ===
> visual.c:1478: Test failed: unexpected colortable on offscreen surface
> 
> === w864 (32 bit visual) ===
> visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00
> visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00
> visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00
> visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00
> visual.c:1478: Test failed: unexpected colortable on offscreen surface
> 
> === w1064 (32 bit visual) ===
> visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00
> visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00
> visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00
> visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00
> visual.c:1478: Test failed: unexpected colortable on offscreen surface
Same as before a no-op patch produces the same issues:
https://testbot.winehq.org/JobDetails.pl?Key=21575

bye
	michael