[PATCH] msvcr120/tests: Add critical section test.
fgouget at free.fr
Mon Mar 28 21:21:31 CDT 2016
On Tue, 22 Mar 2016, Piotr Caban wrote:
> On 03/22/16 17:28, YongHao Hu wrote:
> > How long is a test running acceptable? I want to know a appropriate
> > standard.
> There's no rule for that. In most cases 100ms wait is long enough to
> make sure something works. Of course if the test is useful and it can't
> be written to end quickly it can take much longer. I'm trying to avoid
> tests that calls Sleep if possible.
The TestBot and WineTest impose a 2 minute limit on individual tests
(like msvcr120:msvcr120 or kernel32:process).
Furthermore the TestBot imposes a 30 minute limit on the full test
suite. At 585 tests (and growing all the time), this only allows an
average of about 3 seconds per test. But of course some tests take much
longer so the remainder must be much faster to bring the average down.
Francois Gouget <fgouget at free.fr> http://fgouget.free.fr/
If you think the whole world revolves around you,
quit staring at the GPS display while driving.
More information about the wine-devel