winex11.drv: Use IsRectEmpty() instead of open coding it.
Alexandre Julliard
julliard at winehq.org
Wed May 4 03:15:22 CDT 2016
Ken Thomases <ken at codeweavers.com> writes:
> On May 4, 2016, at 2:58 AM, Alexandre Julliard <julliard at winehq.org> wrote:
>>
>> Michael Stefaniuc <mstefani at redhat.de> writes:
>>
>>> @@ -134,7 +134,7 @@ static inline void reset_bounds( RECT *bounds )
>>>
>>> static inline void add_bounds_rect( RECT *bounds, const RECT *rect )
>>> {
>>> - if (rect->left >= rect->right || rect->top >= rect->bottom) return;
>>> + if (IsRectEmpty(rect)) return;
>>
>> I'm not sure it's an improvement to add a function call in such a simple
>> inline function.
>
> All of these sorts of patches have made me wonder if these
> RECT-related utility functions shouldn't themselves be defined static
> inline in the headers (as well as having real versions for export).
If we are making heavy use of them, then yes, that would probably be
worth it.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list