comdlg32: Use SetRect() instead of open coding it.

Dmitry Timoshkov dmitry at baikal.ru
Wed May 4 05:36:34 CDT 2016


Frédéric Delanoy <frederic.delanoy at gmail.com> wrote:

> >> -        cancel_rc.left = dialog_rc.right - cancel_width - hspacing;
> >> -        cancel_rc.top = dialog_rc.bottom - cancel_height - vspacing;
> >> -        cancel_rc.right = cancel_rc.left + cancel_width;
> >> -        cancel_rc.bottom = cancel_rc.top + cancel_height;
> >> +        SetRect(&cancel_rc,
> >> +                dialog_rc.right - cancel_width - hspacing, dialog_rc.bottom - cancel_height - vspacing,
> >> +                dialog_rc.right - hspacing               , dialog_rc.bottom - vspacing);
> >
> > This is at least very strange and weird formatting of an API call.
> > I don't see anything like that in the changed file.
> >
> > --
> > Dmitry.
> 
> It's for increased readability.

I hope that's a joke.

> Of course, it doesn't show well in
> proportional fonts like those used in emails.

I don't use proportional fonts in e-mails and it still looks quite ugly.
What's the reason of inventing new fancy formatting when doing janitorial
work?

-- 
Dmitry.



More information about the wine-devel mailing list