[PATCH 4/6] d3drm: Implement IDirect3DRMTexture*_GetImage (resend).

Stefan Dösinger stefandoesinger at gmail.com
Sun May 8 11:07:06 CDT 2016


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-05-08 um 11:31 schrieb Aaryaman Vasishta:
> d3drm_img = NULL; d3drm_img =
> IDirect3DRMTexture2_GetImage(texture2); -    todo_wine
> ok(!!d3drm_img, "Failed to get image.\n"); -    todo_wine
> ok(d3drm_img == &initimg, "Expected image returned == %p, got
> %p.\n", &initimg, d3drm_img); +    ok(!!d3drm_img, "Failed to get
> image.\n"); +    ok(d3drm_img == &initimg, "Expected image returned
> == %p, got %p.\n", &initimg, d3drm_img);
This is a problem of the exiting code code more than the patch: The
d3drm_img = NULL assignment is redundant. Since GetImage returns the
image as a return value the destination will be overwritten, no matter
how GetImage behaves. The problem of a getter not writing anything can
only happen when you pass a pointer and the function writes a value to
that pointer.

What happens when GetImage is called on an uninitialized Texture?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXL2QqAAoJEN0/YqbEcdMwYD0P/i4GqKylB9vvWa64h6Hph+li
+tVW8KNgbjaPaJJfvEZRG3t1hToqFogSKU0TBBTnhv7zGuU5wKHr4a+UwkFFjQSx
ww/jzuQXu7coJ28CZrGBeDqMAadR3RCZHcdKD+czzn5bBy/8LCzrX4Id/1qpdf+Y
PZtdtF9R7e1poYjctPJXtcOzJlwtEF3+JkGUiyjcH3kNoammqmpRf6FeSFxXrvUB
frVrNHIaLU6Cg8MaoyC6aYOOuf1KHH/5Nym3kAvR7Ty+0PNo38g23/+DMtN5553r
IvaYHSsmzK10LsH6/xgkDQk9fpkEX6eTgW/wbd+p++L3fauDMjk6KxMVgPFpEF4g
2hRrKw5TTdvY3LftbC5VZDtnKZeFX5hwiysZZEztFLW/Rk85qgJUo36cq9QR1XE6
fwOH77QYO0+bv2+9TXyyh20RIQshLbN4Pzx5jWxC9Ym9InEWevLKXTQrjt+ve5bl
YL+202MXZ1hc/cuCk/HOLrCg2B8XkSN/Sj5ziszhyXJk8kHv/FRyfMa5+p3Ngyrn
ZBE464osVWL8pSdJeadb1Nud7aWVfW+RIaun8RgwDAhFpRnStEZyfW0FxrVkfQBY
BdDTGORUrFDfsVs8xLsQwKI/xaq3vKZJJ2oZbnnIek0P2q0TVYCP8eXlu2o2ARvd
rXSlOmyAYudSsOeqz9ED
=mT+3
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list