[PATCH v2] riched20: Don't call UpdateWindow after setting the background color.

Huw Davies huw at codeweavers.com
Mon May 9 03:05:33 CDT 2016


On Sun, May 08, 2016 at 11:42:59PM -0600, Alex Henrie wrote:
> diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c
> index ae9c0a5..a780c2e 100644
> --- a/dlls/riched20/tests/editor.c
> +++ b/dlls/riched20/tests/editor.c
> @@ -8337,6 +8337,18 @@ static void test_rtf_specials(void)
>      DestroyWindow( edit );
>  }
>  
> +static void test_background(void)
> +{
> +    HWND hwndRichEdit = new_richedit(NULL);
> +
> +    /* set the background color to black */
> +    ValidateRect(hwndRichEdit, NULL);
> +    SendMessageA(hwndRichEdit, EM_SETBKGNDCOLOR, FALSE, RGB(0, 0, 0));
> +    ok(GetUpdateRect(hwndRichEdit, NULL, FALSE), "Update rectangle is empty!\n");
> +
> +    DestroyWindow(hwndRichEdit);
> +}
> +

Please don't add an extra line after the function.

>  
>  START_TEST( editor )
>  {


Otherwise, this looks good.

Thanks,
Huw.



More information about the wine-devel mailing list