[PATCH v2] riched20: Don't call UpdateWindow after setting the background color.

[Huw Davies]

On 9 May 2016, at 15:46, Alex Henrie <alexhenrie24 at gmail.com> wrote:
> 
> 2016-05-09 2:05 GMT-06:00 Huw Davies <huw at codeweavers.com>:
>> On Sun, May 08, 2016 at 11:42:59PM -0600, Alex Henrie wrote:
>>> diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c
>>> index ae9c0a5..a780c2e 100644
>>> --- a/dlls/riched20/tests/editor.c
>>> +++ b/dlls/riched20/tests/editor.c
>>> @@ -8337,6 +8337,18 @@ static void test_rtf_specials(void)
>>>     DestroyWindow( edit );
>>> }
>>> 
>>> +static void test_background(void)
>>> +{
>>> +    HWND hwndRichEdit = new_richedit(NULL);
>>> +
>>> +    /* set the background color to black */
>>> +    ValidateRect(hwndRichEdit, NULL);
>>> +    SendMessageA(hwndRichEdit, EM_SETBKGNDCOLOR, FALSE, RGB(0, 0, 0));
>>> +    ok(GetUpdateRect(hwndRichEdit, NULL, FALSE), "Update rectangle is empty!\n");
>>> +
>>> +    DestroyWindow(hwndRichEdit);
>>> +}
>>> +
>> 
>> Please don't add an extra line after the function.
>> 
>>> 
>>> START_TEST( editor )
>>> {
>> 
>> 
>> Otherwise, this looks good.
> 
> I actually added the blank line before the test_background function,
> it just looks odd because of the way that Git formatted the diff. The
> original code had two blank lines between the last test function and
> the START_TEST function. Are you sure that you want me to reduce that
> to just one blank line separating the two?

Ah right.  Yes, please remove one of the blank lines.

Thanks,
Huw.