[PATCH 1/6] d3drm: Introduce d3drm_texture_destroy helper (v3).

Henri Verbeet hverbeet at gmail.com
Fri May 13 05:24:59 CDT 2016


On 11 May 2016 at 21:19, Aaryaman Vasishta <jem456.vasishta at gmail.com> wrote:
> +void d3drm_texture_destroy(struct d3drm_texture *texture)
This should be static. I.e.:
    +static void d3drm_texture_destroy(struct d3drm_texture *texture)

Adding static prevents the function from being available outside of
texture.c. (See also
http://port70.net/~nsz/c/c89/c89-draft.html#3.1.2.2 for the details,
although "The C Programming Language" by Kernighan & Ritchie makes for
better reading.) Applies to d3drm_validate_image() as well.



More information about the wine-devel mailing list