[PATCH 1/7] d3drm: Use CreateObject in IDirect3DRM*::LoadTexture.

Mon May 16 14:23:13 CDT 2016

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-05-13 um 22:21 schrieb Aaryaman Vasishta:
> -    if (FAILED(hr = d3drm_texture_create(&object)))
> +    if (FAILED(hr = IDirect3DRM_CreateObject(iface, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture, (void **)texture)))
This line is fairly long and could profit from a line break IMHO.

> -    if (FAILED(hr = d3drm_texture_create(&object)))
> +    if (FAILED(hr = IDirect3DRM2_CreateObject(iface, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture2, (void **)texture)))
I think here you could already put the 2 -> 3 thunk from patch 7. It's a minor issue though.

Overall I'd say wait if Henri has any other comments before resending.