[v2 2/3] d3dx9: Implement IsParameterUsed function in effect.

[Paul Gofman]

On 05/26/2016 06:10 PM, Matteo Bruni wrote:
> 2016-05-23 12:40 GMT+02:00 Paul Gofman <gofmanp at gmail.com>:
>> Signed-off-by: Paul Gofman <gofmanp at gmail.com>
> It looks generally good, I only have minor "complaints" (and sorry for
> the delay in reviewing...).
>
>> ---
>>  dlls/d3dx9_36/effect.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++--
>>  1 file changed, 110 insertions(+), 3 deletions(-)
>>
>> diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
>> index 31aa2d6..cdfc494 100644
>> --- a/dlls/d3dx9_36/effect.c
>> +++ b/dlls/d3dx9_36/effect.c
>> @@ -3545,15 +3545,122 @@ static HRESULT WINAPI ID3DXEffectImpl_FindNextValidTechnique(ID3DXEffect* iface,
>>      return E_NOTIMPL;
>>  }
>>
>> +typedef BOOL (*walk_parameter_dep_func)(void *data, struct d3dx_parameter *param);
>> +static BOOL walk_state_dep(struct d3dx_state *state, walk_parameter_dep_func param_func,
>> +        void *data);
>> +static BOOL walk_param_eval_dep(struct d3dx_param_eval *param_eval, walk_parameter_dep_func param_func,
>> +        void *data);
> I guess you intend to reuse all these functions down the line for some
> other API, what are your plans?
Well, I intended to reuse, but later realized that the other "walk"
function I need in 'dirty' param tracking on CommitChanges
implementation are quite different as walk parameter members tree and
not dependencies. Now I am reusing just typedef for the tree mapped
function, I will remove one prototype and move another one near to the
function (I will still need one as there are recursive calls between the
two functions).