[PATCH] comctl32: Use SetRect() instead of open coding it.

Nikolay Sivov nsivov at codeweavers.com
Sat May 28 08:45:02 CDT 2016


      if (dis->itemAction & ODA_FOCUS) {
-	rect.left = xbase + xioff - 1;
-	rect.right = rect.left + txtsize.cx + 2;
-	rect.top = dis->rcItem.top;
-	rect.bottom = dis->rcItem.bottom;
+	SetRect(&rect, xbase + xioff - 1, dis->rcItem.top, rect.left + txtsize.cx + 2, dis->rcItem.bottom);
  	DrawFocusRect(dis->hDC, &rect);
      }

This change is obviously wrong. I think it's better to leave this one as is.




More information about the wine-devel mailing list