[PATCH 2/2] gdiplus: Implement GdipBitmapGetHistogram()

Dmitry Timoshkov dmitry at baikal.ru
Tue Nov 1 07:55:26 CDT 2016


Nikolay Sivov <nsivov at codeweavers.com> wrote:

> +    for (x = 0; x < width; x++)
> +        for (y = 0; y < height; y++)
> +        {
> +            ARGB color;
> +
> +            GdipBitmapGetPixel(bitmap, x, y, &color);
> +            set_histogram_point[format](color, ch0, ch1, ch2, ch3);
> +        }
> +
> +    return Ok;
> +}

One of the very least things that could be done about this very ineffecient
implementation is to make the width traversing an inner loop.

-- 
Dmitry.



More information about the wine-devel mailing list