[PATCH 1/2] crypt32: Import system root certs into volatile registry keys instead of dedicated root store.

Donat Enikeev donat at enikeev.net
Mon Nov 7 11:23:52 CST 2016


Hi Jacek,

Thank you for the adjustments.

There are probably too much questions for the one patch, so only if you 
have another free minute, I would be really grateful if you clarify a 
background under removal of `root_certs_imported` flag, intended to 
skip import if it's supposed to be done already. I do understand that 
this flag will not prevent re-importing by another process, but within 
one given - expected to, as semaphore will not exist by a moment of 
next request for HKLM\Root store, while certificates are all in 
registry already. Without the flag, it will re-import all system 
certificates each time an application is calling for HKLM\Root store. 
It's not a big deal of course, just extra electricity burning by 
certification management applications, using all stores heavily (like 
`certmgr`). On the other hand, I could miss something substantial 
again, if so - just ignore the above, I would hope to figure it out 
eventually

Best,
Donnie

On Пн, ноя 7, 2016 at 7:43 , Jacek Caban <jacek at codeweavers.com> 
wrote:
> It was me sending changed Donat's patches with messed From header. 
> Sorry
> about that. Same for 2/2 patch.
> 
> Jacek
> 
> 




More information about the wine-devel mailing list