Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.

[Donat Enikeev]

Hi Francois,

The question around purposes of using XP SP1 as testing platform is probably to you.

I've just confirmed that tests are working on SP3 (below), so does it make sense to upgrade the testing environment to SP3? Meanwhile I am checking whether the most recent Debian 8.x fails the tests in oppose to the nightly failures reported

Also you might probably want to consider Windows XP *Embedded* as the target testing platform. It seems much more important and sensible, as it has extended support and a lot of corporate software is still there, and *any* case when one decides to move it to Wine&Linux automatically brings level-up for all involved.  

What do you think? And yes, I could put another hack for the tests if XP SP1 support is crucial

X:\winetmp>ver

Microsoft Windows XP [Version 5.1.2600]

X:\winetmp>crypt32_crosstest.exe chain
chain.c:4430: Tests skipped: ignoredBadDateNestingBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: ignoredInvalidDateBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: ignoredInvalidUsageBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: ignoredInvalidUsageBasePolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4430: Tests skipped: invalidExtensionPolicyCheck[0](#0001): error 00000000 doesn't match expected 800b0105, not checking indexes
chain.c:4677: Tests skipped: Couldn't create chain engine
chain.c:4430: Tests skipped: ignoredInvalidDateBasePolicyCheck[0](#0002): error 00000000 doesn't match expected 800b0101, not checking indexes
chain.c:4027: info[0] = 102
chain.c:4027: info[1] = 102
chain.c:4027: info[2] = 10a
chain: 2678 tests executed (0 marked as todo, 0 failures), 7 skipped.

Best,
Donnie


22.11.2016, 12:32, "Donat Enikeev" <donat at enikeev.net>:
> Hi Huw,
>
> I will, though it would be not easy to find XP with Service Pack 1
>
> In this context, and considering Wine is going to report itself as Windows 7, could you or someone else clarify please whether testing on XP SP1 (not the latest service pack 3) is being done for purpose?
>
> Best,
> Donnie
>
> 22.11.2016, 11:59, "Huw Davies" <huw at codeweavers.com>:
>>>   On 21 Nov 2016, at 21:28, Alexandre Julliard <julliard at winehq.org> wrote:
>>>
>>>   Module: wine
>>>   Branch: master
>>>   Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2
>>>   URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85aa7d62515041f6e2
>>>
>>>   Author: Donat Enikeev <donat at enikeev.net>
>>>   Date: Sat Nov 19 21:12:30 2016 +0300
>>>
>>>   crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.
>>>
>>>   Signed-off-by: Donat Enikeev <donat at enikeev.net>
>>>   Signed-off-by: Alexandre Julliard <julliard at winehq.org>
>>>
>>>   ---
>>>
>>>   dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++---------------------
>>>   1 file changed, 352 insertions(+), 306 deletions(-)
>>>
>>>   Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200c85aa7d62515041f6e2
>>
>>  Hi Donat,
>>
>>  This has caused failures on some of Francois’ XP VMs. For example:
>>  http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-winxp-1sp/crypt32:chain.html
>>
>>  Could you take a look?
>>
>>  Thanks,
>>  Huw.