[PATCH] msvcrt: Implement __std_type_info_hash

Piotr Caban piotr.caban at gmail.com
Wed Oct 5 04:05:40 CDT 2016


On 10/05/16 10:57, Dmitry Timoshkov wrote:
> Piotr Caban <piotr.caban at gmail.com> wrote:
>
>>> +    return hash ^ (hash >> 32);
>> This will also cause compilation warning during 32-bit compilation.
>>
>>> diff --git a/dlls/ucrtbase/tests/cpp.c b/dlls/ucrtbase/tests/cpp.c
>>> index 1a01fea..659269c 100644
>>> --- a/dlls/ucrtbase/tests/cpp.c
>>> +++ b/dlls/ucrtbase/tests/cpp.c
>>> @@ -163,7 +163,7 @@ static void test___std_type_info(void)
>>>      ti1.mangled[2] = 0;
>>>      hash1 = p___std_type_info_hash(&ti1);
>>>  #ifdef _WIN64
>>> -    todo_wine ok(hash1 == 0xcbf29ce44fd0bfc1, "hash = %p\n", (void*)hash1);
>>> +    ok(hash1 == 0xcbf29ce44fd0bfc1, "hash = %p\n", (void*)hash1);
>> And this.
>
> This one can't cause a compilation warning since it's conditionally
> compiled.
>
I've thought about this one:
      if(sizeof(void*) == sizeof(int))
          ok(hash1 == 0x40c5b8c, "hash = %p\n", (void*)hash1);
+    else
+        ok(hash1 == 0xaf63bc4c29620a60, "hash = %p\n", (void*)hash1);



More information about the wine-devel mailing list