[PATCH v4 1/2] libwine: Don't call exit in the shared library.
Ken Thomases
ken at codeweavers.com
Wed Oct 12 10:12:35 CDT 2016
On Oct 12, 2016, at 7:52 AM, Alexandre Julliard <julliard at winehq.org> wrote:
>
> Jens Reyer <jre.winesim at gmail.com> writes:
>
>> On 11.10.2016 16:59, Sebastian Lackner wrote:
>>> Before changing things in Winelib, it would first be necessary to modify all
>>> involved tools and dlls to avoid fatal_[p]error for harmless errors.
>>
>> Thanks a lot, that's the advice I've been looking for (obviously not
>> with the hoped for outcome).
>>
>> Unfortunately the todo is beyond my capabilities. I'll discuss that at
>> Debian and propose to drop the patch for now.
>>
>> Instead I'll file a bug here since I haven't heard anyone rejecting the
>> goal of getting rid of exit in the shared library itself.
>
> I don't think that's a useful goal. It's not a bad idea to review its
> usage, and possibly replace it where it makes sense, but there are also
> places where exit is needed.
The reason for this is that libwine is not like other libraries where Debian's check may make sense. It's not a general-purpose library. It's only really useful for Wine itself and for a program which wants to be an alternative Wine loader. The client of libwine will want it to call exit() when needed.
Is there a way to make an exception to Debian's lintian checks?
-Ken
More information about the wine-devel
mailing list