[PATCH v2 4/4] winehid: Implement handing internal ioctls

Aric Stewart aric at codeweavers.com
Thu Oct 13 23:25:50 CDT 2016



On 10/14/16 5:09 AM, Sebastian Lackner wrote:
> On 12.10.2016 18:19, Aric Stewart wrote:
>>
>> Mostly by passing them to the bus driver where platform specific actions
>> happen
>>
>> v2: Suggestion from Sebastian Lackner
>> Signed-off-by: Aric Stewart <aric at codeweavers.com>
>> ---
>>  dlls/winehid.sys/main.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 47 insertions(+)
>>
> 
> This patch no longer applies because of the slightly modified version of
> patch 1/2. I have already prepared a rebased version, but I'm wondering a bit:
> Couldn't we just pass through ALL ioctls (without any filtering in winehid)?
> This would reduce the code complexity even further. HID related FIXMEs could
> also be printed in winebus. hid_internal_dispatch should probably use the
> "hid" debug channel anyway. What do you think?
> 
> Regards,
> Sebastian
> 

Yup, rebased and resent

thanks!
-aric



More information about the wine-devel mailing list