[PATCH] ws2_32: Allow user to enable IP dual stack (v5).
Dmitry Timoshkov
dmitry at baikal.ru
Tue Oct 18 07:51:02 CDT 2016
Roman Pišl <rpisl at seznam.cz> wrote:
> Ok, sorry, I wanted to give him a credit as my patch is only a fine-tuning of
> tests.
Then it's probably better to add From: at the beginng of your patch with
the original author's name, and add your sign-off.
> Is it really possible that get_sock_fd() can fail after a successfull
> create_socket request?
It's better to be on the safe side.
> What should be done if it fails, just skip setting the
> option?
Probably. Have a look at other places that use this combo.
> Are these the only objections and should I send v6?
I have no objections other than the ones mentioned above.
--
Dmitry.
More information about the wine-devel
mailing list