[PATCH 6/9] wined3d: Replace wined3d_buffer_load_sysmem() calls with wined3d_buffer_load_location().
Henri Verbeet
hverbeet at gmail.com
Fri Oct 21 06:15:22 CDT 2016
On 20 October 2016 at 12:50, Józef Kucia <jkucia at codeweavers.com> wrote:
> - /* Download the buffer, but don't permanently enable double buffering */
> - if (!(buffer->flags & WINED3D_BUFFER_DOUBLEBUFFER))
> - {
> - wined3d_buffer_load_sysmem(buffer, context);
> - buffer->flags &= ~WINED3D_BUFFER_DOUBLEBUFFER;
> - }
> + /* Download the buffer, but don't permanently enable double buffering. */
> + wined3d_buffer_load_location(buffer, context, WINED3D_LOCATION_SYSMEM);
> + buffer->flags &= ~WINED3D_BUFFER_DOUBLEBUFFER;
Wouldn't this also clear WINED3D_BUFFER_DOUBLEBUFFER if it was
previously set? Longer term, it's probably inappropriate for
wined3d_buffer_load_location() to set WINED3D_BUFFER_DOUBLEBUFFER to
begin with.
More information about the wine-devel
mailing list