[PATCH] winejoystick.drv: Fix long time consuming task of looking for joysticks
Bruno Jesus
00cpxxx at gmail.com
Thu Sep 1 22:03:10 CDT 2016
On Thu, Sep 1, 2016 at 11:37 PM, Sebastian Lackner
<sebastian at fds-team.de> wrote:
> On 01.09.2016 05:18, Bruno Jesus wrote:
>> + joysticks = scandir(p, &files, filter_js, sort_js);
>
> Usually malloc-like allocations should be avoided in the Wine source. I am
> not sure if Alexandre is willing to make an exception in this case because
> its only a very small amount of memory - nevertheless, replacing with a
> different directory enumeration mechanism should also not be too difficult.
I considered that, but since this DLL is very low-level and is already
using open/read/close/ioctl I thought one more low level call wouldn't
hurt. And since the code is Linux only I really thought it was OK.
But I'm OK if the patch is rejected, if the approach is not accepted
it won't be useful to change the directory listing to winapi as HID
gets closer and closer , it will be better to revert the offender
patch.
> Regards,
> Sebastian
Best wishes,
Bruno
More information about the wine-devel
mailing list