[PATCH] winejoystick.drv: Revert 62876f3fc5feb1ca23d27a6de5adca580d963d0c
Sebastian Lackner
sebastian at fds-team.de
Mon Sep 5 10:08:09 CDT 2016
On 03.09.2016 22:21, Bruno Jesus wrote:
> Copy & paste fail on the commit ID in previous email, sorry.
>
> With Aric's intensive steps into commiting HID code it is simpler to revert this patch (which caused a regression) instead of trying alterantive ways to fix it. Specially because HID will change this whole file anyway.
>
> Superseeds 126184.
>
> Fixes https://bugs.winehq.org/show_bug.cgi?id=41217
>
> Signed-off-by: Bruno Jesus <00cpxxx at gmail.com>
> ---
> dlls/winejoystick.drv/joystick_linux.c | 35 ++++++++--------------------------
> 1 file changed, 8 insertions(+), 27 deletions(-)
I am not sure if it makes much sense to revert your improvements, just because of the
ongoing HID work. When I understand the problem correctly, the performance issues can
also be fixed without in a different way. I think your previous patch was already in
the right direction, my only criticm was the use of malloc/free instead of WINAPI.
Regards,
Sebastian
More information about the wine-devel
mailing list