[PATCH] d3d11/tests: Extend GetDC() tests

Nikolay Sivov bunglehead at gmail.com
Tue Sep 6 04:01:46 CDT 2016


On 06.09.2016 11:54, Henri Verbeet wrote:
> On 5 September 2016 at 21:45, Nikolay Sivov <nsivov at codeweavers.com> wrote:
>> +    static const struct
>> +    {
>> +        const char *name;
>> +        DXGI_FORMAT format;
>> +        unsigned int bit_count;
>> +        DWORD mask_r, mask_g, mask_b;
>> +        BOOL getdc_supported;
>> +    }
>> +    testdata[] =
>> +    {
>> +        {"B8G8R8A8_UNORM",      DXGI_FORMAT_B8G8R8A8_UNORM,    32, 0x00000000, 0x00000000, 0x00000000, TRUE },
>> +        {"B8G8R8A8_TYPELESS",   DXGI_FORMAT_B8G8R8A8_TYPELESS, 32, 0x00000000, 0x00000000, 0x00000000, TRUE },
>> +        {"B8G8R8A8_UNORM_SRGB", DXGI_FORMAT_B8G8R8A8_UNORM,    32, 0x00000000, 0x00000000, 0x00000000, TRUE },
>> +    };
> I guess this was inherited from the d3d9 test, but not all of these
> fields are very useful in the current form of the test. Do you intend
> to add more formats later?
> 

Not right now, no. I think it's safe to remove masks and bit count, as
all documented formats are 8888. I think it's better to keep
getdc_supported though, making it easy to add unsupported cases later.




More information about the wine-devel mailing list