Alexandre Julliard : winex11: Remove support for synthesizing clipboard formats.

Alexandre Julliard julliard at winehq.org
Thu Sep 8 19:55:15 CDT 2016


Ken Thomases <ken at codeweavers.com> writes:

> On Sep 7, 2016, at 10:48 AM, Alexandre Julliard <julliard at winehq.org> wrote:
>> dlls/winex11.drv/clipboard.c      | 454 ++------------------------------------
>> dlls/winex11.drv/winex11.drv.spec |   1 -
>> 2 files changed, 14 insertions(+), 441 deletions(-)
>> 
>> Diff:   http://source.winehq.org/git/wine.git/?a=commitdiff;h=761d244970dd189b1a639121e668a5089fd0112d
>
> Either I'm missing something or this isn't correct.
>
> You've made user32 synthesize formats when a Windows app puts one text
> format on the clipboard but not the others, but you haven't handled
> the case were an external program has put some text on the clipboard.
> For example, if some non-Wine X client puts UTF8_STRING but not STRING
> or text/plain on the clipboard, a Windows program will see
> CF_UNICODETEXT, but not CF_TEXT or CF_OEMTEXT.  That shouldn't be
> possible.

The plan is that the driver will be modified to go through the Windows
API. So if some X client puts text on the clipboard, the X11 driver will
do a SetClipboardData(CF_UNICODETEXT), and user32 will then synthesize
the others.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list