[PATCH] Moved wined3dformat <-> dxgi_format conversion functions into wined3d

[Michael Stefaniuc]

On 09/12/2016 10:50 PM, Matteo Bruni wrote:
> 2016-09-12 10:37 GMT+02:00 Henri Verbeet <hverbeet at gmail.com>:
>> On 10 September 2016 at 18:47, Fabian Maurer <dark.shadow4 at web.de> wrote:
>>> I mean, I
>>> could make a copy from all the d3dx9 code for d3dx11, but it seems more
>>> logical to not just duplicate code.
>>> But where would I put the code to use it in both d3dx9 and d3dx11? A new
>>> folder d3dx_shared for PARENTSRC?
>>>
>> It's largely up to Matteo and Alexandre, but I think there are a few
>> options. We could for example use a single PARENTSRC for d3dx9/10/11.
>> That would still require some thought, since while I'd expect many
>> things to be similar or the same between d3dx9/10/11, there are also a
>> considerable number of differences. Another option could be a static
>> library like libwpp or libwine_port, although that's not a popular
>> option. Maybe it's warranted for d3dx. Maybe there are other options
>> as well.
> 
> I don't quite know what would be the best solution yet. Maybe a static
> library for the code in common between d3dx9/10/11 + PARENTSRC for the
> various _xx versions would be sensible, yes. It's going to be quite a
> bit of work to make the common, d3dx version-agnostic helper functions
> to put in the static lib though (including figuring out what they
> should look like). On the upside, that can be done incrementally,
> moving stuff there piece by piece as needed.
The static library was also my goal for the dmusic and related DLLs.
Alexandre wasn't convinced so the incremental way to get there was to
duplicate the dmobject.[ch] files. "Duplicate" as there are 8 copies, I
just need to resurrect my dmusic cleanup to make those files even
bigger and add more churn to them ;)

bye
	michael