[PATCH 5/5] d3dx11: Implemented D3DX11CompileFromFileW

Fabian Maurer dark.shadow4 at web.de
Mon Sep 19 18:56:32 CDT 2016


Thanks for your feedback.

> > +    UINT filename_converted_len;
> 
> Probably you can call it just "size".
Are you sure? I tried to make it less ambiguous, since there are two sizes 
used.

> This would be okay otherwise but, as mentioned for patch [4/5], maybe
> it's a good idea to implement and make use of
> D3DX11CreateAsyncFileLoaderW() here too.

I fixed the other issues on my local branch and I'll try to get the async parts 
right.




More information about the wine-devel mailing list