[v2 PATCH 2/3] odbccp32: Implement SQLRemoveTranslator/W

Huw Davies huw at codeweavers.com
Tue Apr 4 07:55:52 CDT 2017

On Tue, Apr 04, 2017 at 12:04:04PM +0000, Hugh McMaster wrote:
> It's a matter of taste, but is there a reason why you're mixing
> 16-bit functions (e.g. RegOpenKey) and functions defined for Vista
> and up (e.g. RegGetValue)?  You should use RegOpenKeyEx and
> RegQueryValueEx.
> I realise this sort of mismatching occurs
> throughout odbccp32.c, but to my mind, it is wrong, and should be
> fixed file-wide in a separate patch.>
> I don't know how strongly Huw cares about this though.

As far as I'm concerned, they're all part of the Win32 registry API
and can be used together as appropriate (with the exception of the
tests where we need to avoid APIs added after Win XP).


More information about the wine-devel mailing list