[PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.
bunglehead at gmail.com
Wed Apr 5 07:36:03 CDT 2017
On 05.04.2017 10:15, Stefan Dösinger wrote:
> dlls/comctl32/tests/msg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h
> index 3fa0fae..b30b5d8 100644
> --- a/dlls/comctl32/tests/msg.h
> +++ b/dlls/comctl32/tests/msg.h
> @@ -369,7 +369,7 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index,
> context, expected->message, actual->message);
> - if(todo && !failcount) /* succeeded yet marked todo */
> + if(todo && !failcount && !broken(TRUE)) /* succeeded yet marked todo */
This patch is marked is failed by testbot, but it looks like bot
inability to deal with header file change in tests directory, as it
still tries to run some tests.
Anyway, could you make it look similar to user32/tests/msg.c? It's using:
if( todo && !failcount) /* succeeded yet marked todo */
if (!strcmp(winetest_platform, "wine")) dump++;
Platform is tested directly. It's not the only place where it's done
like that, and it's more readable than broken(1), I think.
More information about the wine-devel