[PATCH 2/2] wmvcore: Add WMReader stubs

Nikolay Sivov bunglehead at gmail.com
Fri Apr 7 00:53:01 CDT 2017


On 07.04.2017 6:51, Jefferson Carpenter wrote:
> Adds interfaces used by IMesh in bug 42416, except for these:
> 
> 5c938aeb-6378-479e-bfd5-eafba63dc6e9
> 7af7d5ed-4ef9-48da-a4b6-8ea7eb38f5cc
> ---
>  dlls/wmvcore/wmvcore_main.c | 1301 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 1301 insertions(+)
> 

Hi,

this is too much for a single patch. Please split it up and add some
tests that shows such interfaces are actually supported.

To add tests create a 'tests' directory, Makefile.in in it, and
wmvcore.c (file name could be different), where you place tests.
You'll have to modify configure.ac to add WINE_CONFIG_TEST line in it.
If you need to link to wmvcore.dll from your test, you'll need to modify
WINE_CONFIG_DLL too, to include implib directive.




More information about the wine-devel mailing list