[PATCH 01/10] wined3d: Introduce struct wined3d_dirty_regions.

Matteo Bruni matteo.mystral at gmail.com
Mon Apr 17 15:44:54 CDT 2017

FWIW I broadly agree with Stefan's comments and I have another small one.

2017-04-17 18:14 GMT+02:00 Stefan Dösinger <stefandoesinger at gmail.com>:
> Patch 1:
> Am 2017-04-17 um 15:47 schrieb Masanori Kakura:
>> +struct wined3d_dirty_regions
>> +{
>> +    UINT left;
>> +    UINT top;
>> +    UINT right;
>> +    UINT bottom;
>> +    UINT front;
>> +    UINT back;
>> +    struct wined3d_dirty_regions *next;
>> +};
> A standard wine list would be better IMHO.

Yeah. Have a look at include/wine/list.h, also you have many examples
of its use in wined3d already.

In addition, embedding a struct wined3d_box instead of the individual
fields would probably be nicer. Similarly for passing the extents
around e.g. as function arguments in patch 2.

I haven't really looked at the patches in detail but the general
approach seems fine. Thank you for your work!

More information about the wine-devel mailing list