Review | endproc.c: Implement ProcessPage_OnEndProcessTree

[Aaryaman Vasishta]

Forgot to CC wine-devel..

On Fri, Apr 21, 2017 at 12:47 AM, Aaryaman Vasishta <
jem456.vasishta at gmail.com> wrote:

> Hi,
>
> On Thu, Apr 20, 2017 at 6:51 AM, Akarsha Sehwag <akarsha15010 at iiitd.ac.in>
> wrote:
>
>> Hi
>> Could someone take out a little time to review the code once?
>> Bug I intend to solve: https://bugs.winehq.org/show_bug.cgi?id=39640
>>
>> I am new to wine. So, I would appreciate suggestions regarding my coding
>> style if that's not-so-perfect according to wine standards. Or any other
>> problems with the code I have written. I apologize for submitting an
>> untested code earlier. I hope now it works fine.
>>
> No worries! your efforts in contributing is always appreciated :)
>
>
> /*-------------------------------------------CODE-----------
>> ---------------------------------------*/
>>
> Try using diffs/patches instead of manually copying them in this format.
> Diffs are easier to apply and test with using git. That's how Stefan was
> able to detect compilation errors in the patches you sent over on
> wine-patches. I suggest sending another email with the changes in a diif
> format if possible.
>
>> *//DOUBT: *Would sizeof(list->pid) be better or sizeof(int)?
>> //Since in the former case, since list->pid is actually a pointer to
>> DWORD, so //sizeof(list->pid) would return 8 bytes and not 4 bytes.
>>
>> }
>>
> Probably sizeof(DWORD) would be fine as well. In general, try following
> what the surrounding, previously committed code is doing.
> FWIW, pointers don't necessarily have to be 8 bytes in size. The size of a
> pointer depends on whether your application is compiled as 32 or 64 bit.
> It's possible to e.g. compile a program as 32 bit on a 64 bit machine.
> For wine in 64 bit: https://wiki.winehq.org/FAQ#Is_there_a_64_bit_Wine.3F
>
> Cheers,
> Aaryaman
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20170421/137bb8b7/attachment.html>