[PATCH] user32: add GetAutoRotationState/GetDisplayAutoRotationPreferences stubs

Huw Davies huw at codeweavers.com
Fri Apr 21 02:44:05 CDT 2017


On Thu, Apr 20, 2017 at 05:33:15PM -0500, Austin English wrote:
> diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c
> index fa0502e..3581235 100644
> --- a/dlls/user32/misc.c
> +++ b/dlls/user32/misc.c
> @@ -910,3 +910,24 @@ LRESULT WINAPI ImeWndProcW( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam )
>  
>      return DefWindowProcW(hwnd, msg, wParam, lParam);
>  }
> +
> +/**********************************************************************
> + * GetAutoRotationState [USER32.@]
> + */
> +BOOL WINAPI GetAutoRotationState( AR_STATE *state )
> +{
> +    *state = AR_NOT_SUPPORTED;
> +    FIXME("(%p): stub\n", state);
> +    return TRUE;
> +}
> +

I think these would be better in sysparams.c.  I realise that there
are already functions of this nature in misc.c - they could probably
be moved across too.  User32 does indeed have some odd 'misc' like
functions, but these aren't them.

Also, we'd generally put the FIXME() at the start of the function,
not after the assignment.

Apart from that, this looks good to me.

Huw.



More information about the wine-devel mailing list