[PATCH] tests: Don't evaluate the todo condition when not running on Wine.
huw at codeweavers.com
Fri Apr 21 09:05:45 CDT 2017
On Fri, Apr 21, 2017 at 03:49:42PM +0200, Alexandre Julliard wrote:
> Huw Davies <huw at codeweavers.com> writes:
> > On Fri, Apr 21, 2017 at 03:31:14PM +0200, Sebastian Lackner wrote:
> >> I don't mind if its changed, but please note that it was intentional to
> >> check "is_todo" first. The idea was that side effects (like assigning
> >> variables, changing last error, ...) are applied on both Wine and Windows.
> >> Just think about something like:
> >> FirstCall();
> >> todo_wine_if(SecondCall())
> >> ok(GetLastError() == ..., "\n");
> >> With your patch applied, it will test two entirely different things on
> >> Windows (error from FirstCall) and Wine (error from SecondCall), which
> >> would also be confusing.
> > Yeah, I'm aware that this will make a difference in a case like this,
> > but we should avoid relying on side effects of the condition. I'm
> > not particularly bothered either way by this patch, so I'm not going
> > to argue for it too much ;-)
> Note that the platform being set to "wine" doesn't guarantee that you
> are running on Wine, or that you are running against the builtin dll.
> It's not likely to be an issue in this case, but you should still verify
> the pointer before calling it.
Ah yes. Ok, let's drop this.
More information about the wine-devel